Core-Wallets/monacoin
3
0
Fork 0
Code Issues Pull requests Projects Releases 18 Packages Wiki Activity Actions

[backport]Fix build failure on Ubuntu Hirsute #80

Merged
wakiyamap merged 2 commits from fix_build_hirsute into master-0.17 2021-02-13 00:02:43 +00:00
Conversation 7 Commits 2 Files changed 3 +35 -34
wakiyamap commented 2021-01-30 21:39:47 +00:00 (Migrated from github.com)
Copy link

Fix https://github.com/monacoinproject/monacoin/issues/79

Fix https://github.com/monacoinproject/monacoin/issues/79
tcejorpniocanom (Migrated from github.com) reviewed 2021-01-30 21:39:47 +00:00
wakiyamap commented 2021-02-06 02:13:46 +00:00 (Migrated from github.com)
Copy link

As far as I tested it was fine.

As far as I tested it was fine.
wakiyamap commented 2021-02-10 04:37:37 +00:00 (Migrated from github.com)
Copy link

@cryptcoin-junkey @tcejorpniocanom
I asked for a review, but if you are busy, I will test it again and merge it.
I will test it too. If there's a problem, Please reply by Feb. 13(UTC).

P.S. No cat carcasses will be included in this pull request.

@cryptcoin-junkey @tcejorpniocanom I asked for a review, but if you are busy, I will test it again and merge it. I will test it too. If there's a problem, Please reply by Feb. 13(UTC). P.S. No cat carcasses will be included in this pull request.
cryptcoin-junkey commented 2021-02-11 07:32:33 +00:00 (Migrated from github.com)
Copy link

@wakiyamap Let me make sure. Can we build binaries on older versions of Ubuntu after merged this PR?

@wakiyamap Let me make sure. Can we build binaries on older versions of Ubuntu after merged this PR?
👍 1
wakiyamap commented 2021-02-11 07:44:36 +00:00 (Migrated from github.com)
Copy link

@cryptcoin-junkey I have confirmed this in ubuntu 18.04. But after reading this, I realized I haven't tried debian, so I'll check.

@cryptcoin-junkey I have confirmed this in ubuntu 18.04. But after reading this, I realized I haven't tried debian, so I'll check.
wakiyamap commented 2021-02-11 09:31:24 +00:00 (Migrated from github.com)
Copy link

I've confirmed the build for Ubuntu16.04 and debian9.

I've confirmed the build for Ubuntu16.04 and debian9.
👍 1
cryptcoin-junkey (Migrated from github.com) approved these changes 2021-02-12 02:32:30 +00:00
cryptcoin-junkey (Migrated from github.com) left a comment
Copy link

I checked on Debian 10. LGTM.

I checked on Debian 10. LGTM.
Sign in to join this conversation.
Reviewers
No reviewers
tcejorpniocanom
cryptcoin-junkey
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Core-Wallets/monacoin!80
No description provided.