Remove bignum.h #74

Merged
wakiyamap merged 1 commit from remove_bignum into junkey-dev-0.18 2020-09-06 07:51:51 +00:00
wakiyamap commented 2020-08-07 23:04:05 +00:00 (Migrated from github.com)

In 0.20.0, openssl dependency will be removed, so remove the bignum.h file first.

After compiling, the checkpoint is removed and mainnet and testnet are successfully synchronized.

Attention: This pull request is for junkey-dev-0.18

In 0.20.0, openssl dependency will be removed, so remove the bignum.h file first. After compiling, the checkpoint is removed and mainnet and testnet are successfully synchronized. Attention: This pull request is for `junkey-dev-0.18`
yamada-guro-baru (Migrated from github.com) reviewed 2020-08-07 23:51:40 +00:00
@ -33,8 +31,8 @@ unsigned int static KimotoGravityWell(const CBlockIndex* pindexLast, const CBloc
int64_t PastRateActualSeconds = 0;
yamada-guro-baru (Migrated from github.com) commented 2020-08-07 23:51:39 +00:00

tab? You're better off with space.

tab? You're better off with space.
wakiyamap (Migrated from github.com) reviewed 2020-08-08 02:06:55 +00:00
@ -33,8 +31,8 @@ unsigned int static KimotoGravityWell(const CBlockIndex* pindexLast, const CBloc
int64_t PastRateActualSeconds = 0;
wakiyamap (Migrated from github.com) commented 2020-08-08 02:06:55 +00:00

oh......sorry. solved

oh......sorry. solved
yamada-guro-baru (Migrated from github.com) reviewed 2020-08-08 22:42:37 +00:00
@ -33,8 +31,8 @@ unsigned int static KimotoGravityWell(const CBlockIndex* pindexLast, const CBloc
int64_t PastRateActualSeconds = 0;
yamada-guro-baru (Migrated from github.com) commented 2020-08-08 22:42:37 +00:00

It's easy arith_uint256() instead of bnTarget

英語に自信が無いので日本語で

arith_uint256型で定義したbnTargetと言う変数に入れてから計算していますが、今まで(CBigNum())のようにarith_uint256()を使っては如何でしょうか?
その方が行数と変数が減ります。

example
arith_uint256().SetCompact(BlockReading->nBits)

It's easy `arith_uint256()` instead of `bnTarget` 英語に自信が無いので日本語で arith_uint256型で定義したbnTargetと言う変数に入れてから計算していますが、今まで(CBigNum())のようにarith_uint256()を使っては如何でしょうか? その方が行数と変数が減ります。 example `arith_uint256().SetCompact(BlockReading->nBits)`
wakiyamap (Migrated from github.com) reviewed 2020-08-08 23:01:46 +00:00
@ -33,8 +31,8 @@ unsigned int static KimotoGravityWell(const CBlockIndex* pindexLast, const CBloc
int64_t PastRateActualSeconds = 0;
wakiyamap (Migrated from github.com) commented 2020-08-08 23:01:46 +00:00

Fixed. Thanks.

kgwdgw部分も含めてちゃんと通過したので問題なさそうです。
確かにこっちの方が分かりやすい。

Fixed. Thanks. ~~kgw~~dgw部分も含めてちゃんと通過したので問題なさそうです。 確かにこっちの方が分かりやすい。
cryptcoin-junkey (Migrated from github.com) approved these changes 2020-09-06 07:51:22 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Core-Wallets/monacoin!74
No description provided.