QR code and Verify Message buttons on File->Receive Addresses menu #1

Closed
opened 2016-03-22 15:28:58 +00:00 by ny2cafuse · 5 comments
ny2cafuse commented 2016-03-22 15:28:58 +00:00 (Migrated from github.com)

QR code and Verify Message buttons on File->Receive Addresses menu do not WAI. QR code button should return the popup page that is displayed when you double-click on a receive address in the receive tab. Verify Message button can be removed, as the File->Verify Message menu option can be used instead.

QR code and Verify Message buttons on File->Receive Addresses menu do not WAI. QR code button should return the popup page that is displayed when you double-click on a receive address in the receive tab. Verify Message button can be removed, as the File->Verify Message menu option can be used instead.
ny2cafuse commented 2016-03-22 15:42:43 +00:00 (Migrated from github.com)

May or may not be an issue at this time depending on the Qt5 update to the wallet. Will discuss further with the team to find out if it should be addressed now or just roll it into the next update.

May or may not be an issue at this time depending on the Qt5 update to the wallet. Will discuss further with the team to find out if it should be addressed now or just roll it into the next update.
BioMike commented 2016-05-09 21:23:53 +00:00 (Migrated from github.com)

This goes in the next version. I'll have a look into it.

This goes in the next version. I'll have a look into it.
BioMike commented 2016-05-10 21:26:34 +00:00 (Migrated from github.com)

Ok, so... when I copied over the interface from the old wallet, these buttons copied over, but their underlying workings are non-existent in the DGB code base. The QR-code should work from the payment requests of the "receive" screen. I'm not sure if anyone uses the message verification feature, or that we should keep that feature, as it is more of an "advanced" feature (which has more to do with cryptography then sending payments).

So, 2 options:

  1. Copy over all the code to implement the features that the buttons should do.
  2. Ditch the buttons from that screen. QR-code feature is covered by the payment requests.
Ok, so... when I copied over the interface from the old wallet, these buttons copied over, but their underlying workings are non-existent in the DGB code base. The QR-code should work from the payment requests of the "receive" screen. I'm not sure if anyone uses the message verification feature, or that we should keep that feature, as it is more of an "advanced" feature (which has more to do with cryptography then sending payments). So, 2 options: 1) Copy over all the code to implement the features that the buttons should do. 2) Ditch the buttons from that screen. QR-code feature is covered by the payment requests.
ny2cafuse commented 2016-05-10 23:39:44 +00:00 (Migrated from github.com)

I say ditch the buttons. That or at least redirect the QR link to the the qt qr window from the payment request screen.

I say ditch the buttons. That or at least redirect the QR link to the the qt qr window from the payment request screen.
BioMike commented 2016-05-30 21:17:41 +00:00 (Migrated from github.com)

Fixed in commit f1be536. Closing

Fixed in commit f1be536. Closing
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Core-Wallets/Auroracoin#1
No description provided.